Look at the great new feature ;)

[jaker]

I can't reproduce the error on my own MSIE6 on NT4 and W2k, haven't tried it on Win98 though.

... and I'm using Win98

That's me, forgot to login after clicking the email notification link...
--jaker

[ug7t]

Has every user the ability to use this form?

Makes life foor woombel and his friends a lot easier

BTW, great work

guess you are right:

2002-07-16 18:31:12.
2002-07-16 18:31:12.
2002-07-16 18:31:12.
2002-07-16 18:31:12.

R@lf`1959 using the top-notch mass insert thingy ;-(

[avij]

Isn't it so that there are no serials ending on a '0' ?
So maybe you can change this, so an ending zero isn't accepted ?

As far as I'm aware, no serial number should end in zero, so checking for that error could be included in the JavaScript code, here's the new code:

Code: Select all

--- massinsert4.html    Wed Jul 10 22:23:08 2002
+++ massinsert4.html.new        Tue Jul 16 20:01:23 2002
@@ -561,7 +561,7 @@
                                checkDigit-=9;
                }
 
-               if(checkDigit != 8) {
+               if(checkDigit != 8 || ser.charAt(11) == '0') {
                        document.notes.elements.startIndex+elementsPerRow*row+3].className="inputwrong";
                } else {
                        document.notes.elements.startIndex+elementsPerRow*row+3].className="inputok";

We could check for some more errors as well -- I don't think there are any short codes that have three zeroes in them right next to the print works code (ie. x000xn), or any short codes that'd end in zero, for example. Here's the code snippet for doing that, for those who are interested:

Code: Select all

--- massinsert4.html    Tue Jul 16 20:01:23 2002
+++ massinsert4.new.html        Tue Jul 16 20:32:26 2002
@@ -521,8 +521,9 @@

        document.notes.elements[startIndex+elementsPerRow*row+2].value
        =fixTypos(document.notes.elements.startIndex+elementsPerRow*row+2].value,"ANNNAN").toUpperCase();
-       var validSC = /^[A-U][0-9][0-9][0-9][A-Z][0-9]$/;
-       if(validSC.test(document.notes.elements.startIndex+elementsPerRow*row+2].value)) {
+       var validSC = /^[A-U][0-9][0-9][0-9][A-Z][1-9]$/;
+       if(validSC.test(document.notes.elements.startIndex+elementsPerRow*row+2].value)
+           && parseInt(document.notes.elements.startIndex+elementsPerRow*row+2].value.substr(1,3))>0) {
                        document.notes.elements.startIndex+elementsPerRow*row+2].className="inputok";                                         
        } else {
                        document.notes.elements.startIndex+elementsPerRow*row+2].className="inputwrong";   

(someone should check that there really aren't any such short codes before using the above modification, I'm just guessing here..)

However, I'd rather leave most of the input checking to the PHP side, as it'll have to check the input again anyway. There are some interesting properties in the combination of serial number, short code and note value that could be checked in JavaScript, but for the sake of project integrity they shouldn't be checked using publicly accessible JavaScript code (and not discussed here for that matter).. Some obvious typos can be checked for using this JavaScript method, but checking for intentionally incorrect input should be done somewhere else. That's why some of my validation checks are somewhat 'easy', ie. they allow short codes such as A999Z9 which are, um, somewhat less likely to be correct.

edit: phpbb screws up the formatting of my code, sorry. I hope you get the idea anyway..

[smh]

Dunno if it's really necessary to check for 3 zero's, but it shouldn't hurt anyway. (well it'll cost me some cpu time)

But maybe a check for a valid printer letter should be possible or is that in place already?

[wouter]

just used the mass insert for 3 notes and i worked perfectly

[emmem]

Today I used the MIF to enter 3 bills (that’s all I got today ).

I had 2 printer codes with a G at the 5-the position. After clicking the GO button the G was suddenly changed into 6 (T001G1 became T00161).

I returned to the form. Corrected them both into G again. Pressed GO and MIF changed the first into 6 the second bill was accepted.

[avij]

But maybe a check for a valid printer letter should be possible or is that in place already?

Yes, it'll check that the short code begins with a letter from A to U. This is actually somewhat incorrect, as the lowest printer code currently in use is D, and the letters I, O and Q aren't used at all for clarity reasons. I think I saw a listing of all printer codes somewhere, and the letters A to C were reserved to someone but those printers haven't printed any notes yet.. or that's my recollection, I may be wrong

edit: Ok, I've changed my mind a bit about this, perhaps it'd be better if the javascript allowed printer codes D-H,J-N,PRTU after all.. let's add the missing printer codes when we start seeing them

[avij]

I had 2 printer codes with a G at the 5-the position. After clicking the GO button the G was suddenly changed into 6 (T001G1 became T00161).

Strange.. Were you using MSIE6 on Win9x by any chance? Was the short code field green before you pressed the Go button? It might be related to the hidden form field problem mentioned above -- the code may have tried to "fix" your short code using the serial number's template.

[emmem]

I had 2 printer codes with a G at the 5-the position. After clicking the GO button the G was suddenly changed into 6 (T001G1 became T00161).

Strange.. Were you using MSIE6 on Win9x by any chance? Was the short code field green before you pressed the Go button? It might be related to the hidden form field problem mentioned above -- the code may have tried to "fix" your short code using the serial number's template.

Oops. I used Opera 6.03 under Win98.
I'll try to find out where the problem is, but can't promise anything before the weekend.

[avij]

Oops. I used Opera 6.03 under Win98.
I'll try to find out where the problem is, but can't promise anything before the weekend.

Oh yes, you were the Opera fellow.. I think I've found a way to make the form work for Opera and MSIE6+Win9x, I hope to have the fixes included into EBT shortly. The background colours still won't change with Opera, but I still blame Opera for that

[bhoeyb]

just used the mass insert for 3 notes and i worked perfectly

Me too, no problem Great

[francky]

Very cool!!!

Just one thing: the year!
I register my note in my PALM. i write value, short code, N° and comment...but not the Year
Never mind ...it a very cool newness

[smh]

Just moderated about 15 bills from our friends woombel and R@lf

All the new features make it really easy for them. 1 makes a csv file from his bills, the other loads the file and enters them into the database.

Thes 15 hits were entered within 10 seconds.


BTW Phillipe, can you remove that annoying popup window which appears after a bill is moderated. Even better would be if it brings you back to the hit list straight away.

[HNL]

Just moderated about 15 bills from our friends woombel and R@lf

All the new features make it really easy for them. 1 makes a csv file from his bills, the other loads the file and enters them into the database.

Yup, it is true, and in this tempo, it is easy for woombel to stand with 9 other woombelers in the whole top 10 with fake hits and in my opinion fake banknotes: I think only woombel is entering "real" banknotes.

But: the new feature works great !

[EuroBillTracker]

Just moderated about 15 bills from our friends woombel and R@lf

All the new features make it really easy for them. 1 makes a csv file from his bills, the other loads the file and enters them into the database.

Thes 15 hits were entered within 10 seconds.

You mean the first time the bill was entered was ten seconds before the second time ?

BTW Phillipe, can you remove that annoying popup window which appears after a bill is moderated. Even better would be if it brings you back to the hit list straight away.

I did it that way because it was the fastest way to do it. I could change it to make it go to the list I guess but it might take a little time.